Repository navigation
Conversation
gnalh
commented
Oct 28, 2025
gnalh
commented
Contributor
- add missing timestamp fields
- Note: xcresult doesn't provide timestamps directly, we have to grab the test plan timestamp and use that
- update parser to populate id field
- add tests that verify bindings
|
Merging to
|
| Some("testsuite"), | ||
| Some("test_variant_truncation2"), | ||
| None, | ||
| "", |
Contributor
There was a problem hiding this comment.
Can we get a second case to test that we're getting the right id with a variant set? (There's a variant_wrapper function in the same file that defines gen_info_id for the correct behaviour)
Contributor
Author
There was a problem hiding this comment.
Even before this change, it looks like variant wasn't set up to be supported with xcresult. No customers have needed it yet, so I'll add a ticket to track.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 72.53% 73.00% +0.47%
==========================================
Files 72 72
Lines 15749 15960 +211
==========================================
+ Hits 11423 11652 +229
+ Misses 4326 4308 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmillar-trunk
approved these changes
Oct 28, 2025
gnalh
force-pushed
the
gabe/trunk-16886-id-field-is-not-being-set-for-xcresult-internalbin
branch
from
October 29, 2025 15:48
d232945 to
b839d72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.