Skip to content

Fix main smoke tests - #802

Merged
trunk-io[bot] merged 2 commits into
mainfrom
gabe/trunk-16853-broken-darwin-builds
Oct 24, 2025
Merged

trunk-io[bot] merged 2 commits into
mainfrom
gabe/trunk-16853-broken-darwin-builds

Conversation

@gnalh

@gnalh gnalh commented Oct 24, 2025 •

Copy link
Copy Markdown
Contributor

We need to pin the cross-rs version and update our rust version. The newest version of home being pulled in requires rust 1.88

https://github.com/trunk-io/analytics-cli/actions/runs/18786944223/job/53607533537

@trunk-io

trunk-io Bot commented Oct 24, 2025 •

Copy link
Copy Markdown

😎 Merged successfully - details.

@codecov-commenter

codecov-commenter commented Oct 24, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.77%. Comparing base (06c3af0) to head (1d4a027).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   73.15%   72.77%   -0.38%     
==========================================
  Files          72       72              
  Lines       17758    15749    -2009     
==========================================
- Hits        12991    11462    -1529     
+ Misses       4767     4287     -480     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gnalh
gnalh force-pushed the gabe/trunk-16853-broken-darwin-builds branch 3 times, most recently from 7e78c86 to 8496610 Compare October 24, 2025 17:09
@gnalh
gnalh force-pushed the gabe/trunk-16853-broken-darwin-builds branch from 8496610 to fa87f77 Compare October 24, 2025 17:13
@gnalh gnalh changed the title pin cross-rs version Fix main smoke tests Oct 24, 2025
@gnalh
gnalh marked this pull request as ready for review October 24, 2025 17:16
@trunk-staging-io

trunk-staging-io Bot commented Oct 24, 2025 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@trunk-io
trunk-io Bot merged commit 47b7127 into main Oct 24, 2025
14 checks passed
@trunk-io

trunk-io Bot commented Oct 24, 2025 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants