Repository navigation
trunk-merge/pr-1213/ef26ca32-d104-435d-a4f5-bca702572469 - #1220
Closed
trunk-io[bot] wants to merge 5 commits into
Closed
trunk-io[bot] wants to merge 5 commits into
trunk-io[bot] wants to merge 5 commits into
Conversation
With TRUNK_QUARANTINE_QUERY_FAILURE_EXIT=true, examples after a failed quarantine lookup are skipped from a before(:example) hook. A plain `before` is appended, so any before hooks the suite configured before requiring trunk_spec_helper still ran (DB setup, fixtures, etc.) for an example that was then skipped. Register it with prepend_before so the skip happens first. Hook registration moves into RSpec::Trunk.install(config, run) so it can be exercised against a sandboxed configuration. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- Abort + in-place retries: RSpec starts no new examples once wants_to_quit is set, so the abort hook only fired for an example re-run in place by rspec-retry, and its skip replaced the failure: an always-failing example finished pending and the run exited 0. The hook now re-raises the failure that aborted the run. - --dry-run: every example was recorded as passed and uploaded. The listener now records and uploads nothing in a dry run. - before(:context) errors: each example's failure was quarantined, but the group still returned false, failing the run. A group whose examples all passed or are pending now reports as passed. - A quarantined example that failed again in an after hook kept only the last error; failures now accumulate in a MultipleExceptionError. - Start/finish times were truncated to whole seconds. add_test now takes f64 epoch seconds and keeps microseconds. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- A group RSpec failed now passes only when Trunk is active and every example's failure was quarantined. A green status alone let a crashing before(:context) over pending examples (error hidden in pending_exception, status :passed) exit 0 where plain RSpec exits 1. - The abort replays the first failure (the one whose lookup failed), not whichever came last, and the replay skips the quarantine lookup. - Quarantined failures combine within an attempt only; the prepended before hook resets them as each attempt starts. - Comment on the prepended hook no longer claims around hooks are skipped. - timestamp_from_epoch_secs uses prost_wkt_types' From<DateTime<Utc>>. - chrono >= 0.4.35, where DateTime::from_timestamp_micros first appears. - Test harness: FakeReport handles try_save, which CI reaches because it sets TRUNK_LOCAL_UPLOAD_DIR; it also counts lookups. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
+ Coverage 83.86% 84.08% +0.22%
==========================================
Files 74 74
Lines 17884 17888 +4
==========================================
+ Hits 14998 15041 +43
+ Misses 2886 2847 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
trunk-io
Bot
deleted the
trunk-merge/pr-1213/ef26ca32-d104-435d-a4f5-bca702572469
branch
October 6, 2026 20:52
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 23cdf288185f557a02af3b9132e1ad8879f0b259.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 1213.