Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for the Anki Sync Server Enhanced dashboard by separating the sync service port from the dashboard/WebUI port and wiring the new settings through the template and UI schema.
Changes:
- Introduces separate
sync_portandweb_portconfiguration (including new test values). - Updates the rendered compose template to use
sync_portfor sync/healthcheck and adds dashboard-related environment variables and portal behavior. - Adds an app migration for the port key rename and bumps the app version to
1.1.5.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ix-dev/community/anki-sync-server/templates/test_values/basic-values.yaml | Adds network.sync_port alongside network.web_port in test values. |
| ix-dev/community/anki-sync-server/templates/docker-compose.yaml | Switches sync behavior to sync_port and introduces dashboard env/port handling + portal gating. |
| ix-dev/community/anki-sync-server/questions.yaml | Adds UI configuration for the new web_port and keeps sync_port as a separate port. |
| ix-dev/community/anki-sync-server/migrations/rename_web_port | Migration intended to move old web_port config to sync_port. |
| ix-dev/community/anki-sync-server/app_migrations.yaml | Registers the new migration for upgrades from <= 1.1.4. |
| ix-dev/community/anki-sync-server/app.yaml | Bumps chart version from 1.1.4 to 1.1.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.