Open
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new NetBird Server community app (management server + dashboard) with generated config and required TrueNAS app metadata.
Changes:
- Introduces the NetBird Server app definition (metadata, images, questions, readme, and test values).
- Adds the app’s template composition (docker-compose template + helper macro to generate/update config via
yq). - Vendors
base_v2_3_2rendering library code + associated tests under the app’stemplates/library/directory.
Reviewed changes
Copilot reviewed 83 out of 85 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ix-dev/community/netbird-server/templates/test_values/basic-values.yaml | Adds CI/test install values for the new app. |
| ix-dev/community/netbird-server/templates/macros/config.sh | Adds helper script macro to write/update NetBird config with yq. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/volumes.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/volume_types.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/volume_sources.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/volume_mount_types.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/volume_mount.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/truenas_client.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tmpfs.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_validations.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_truenas_client.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_sysctls.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_security_opts.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_restart.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_resources.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_render.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_portal.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_notes.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_networks.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_labels.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_functions.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_formatter.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_extra_hosts.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_expose.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_environment.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_dns.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_device_cgroup_rules.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_device.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_depends.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_configs.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/test_build_image.py | Adds unit tests for vendored base library. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/tests/init.py | Test package marker for vendored base library tests. |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/sysctls.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/storage.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/security_opts.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/restart.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/resources.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/render.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/ports.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/portals.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/notes.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/networks.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/labels.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/healthcheck.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/functions.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/formatter.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/extra_hosts.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/expose.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/error.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/environment.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/docker_client.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/dns.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/devices.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/device_cgroup_rules.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/device.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_tika.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_solr.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_redis.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_postgres.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_perms.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_mongodb.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_memcached.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_meilisearch.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_mariadb.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_guacd.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_elastic.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps_cron.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deps.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/deploy.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/depends.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/configs.py | Vendored base library component (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/library/base_v2_3_2/init.py | Base library package marker (base_v2_3_2). |
| ix-dev/community/netbird-server/templates/docker-compose.yaml | Main template composing config helper + server + dashboard containers. |
| ix-dev/community/netbird-server/ix_values.yaml | Declares app images and template constants. |
| ix-dev/community/netbird-server/item.yaml | Adds catalog metadata (category/tags/icon). |
| ix-dev/community/netbird-server/app.yaml | Adds app metadata (versioning, capabilities, run-as context, sources). |
| ix-dev/community/netbird-server/README.md | Adds minimal app README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1674
Currently only management server + dashboard.
Proxy container will be added on subsequent PR once verified that base thing works and that is actual need for the proxy container. As it seems that in order to setup proxy there needs to be a "dance". ie first install it, create a token and then go back to enable the proxy container