Enable type checking for trino.client and trino.dbapi - #638
Closed
azawlocki-sbdt wants to merge 1 commit into
Closed
Enable type checking for trino.client and trino.dbapi#638azawlocki-sbdt wants to merge 1 commit into
azawlocki-sbdt wants to merge 1 commit into
Conversation
Fix type annotations so that mypy can check trino.client and
trino.dbapi without any type violations.
Behavioral changes:
* When called before cursor.execute():
* iter(cursor) now raises ProgrammingError instead of
TypeError: iter() returned non-iterator of type 'NoneType'
* cursor.fetchone()/fetchmany()/fetchall() now raise
ProgrammingError instead of AssertionError (TypeError with -O)
* cursor.genall() now raises ProgrammingError instead
of AttributeError
* TrinoRequest(max_attempts=n) with n < 1 now raises ValueError,
instead of failing on first request with UnboundLocalError.
Fixes:
* trino.dbapi.TimeFromTicks() now works correctly, previously
it tried to use undefined datetime.localtime
* TrinoUserError() can be formatted, previously str(error) raised
AtttributeError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type annotations so that mypy can check trino.client and trino.dbapi without any type violations.
Behavioral changes:
Fixes:
Description
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: