Polish Review deleted-file and conflict side UI - #255
Draft
Ziinc wants to merge 2 commits into
Draft
Conversation
Show a Deleted badge and File deleted placeholder instead of full minus-line hunks for deleted files. In conflict cards, render a dedicated side card when one side deleted the file. Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
Creating a new shared.txt on home before branching did not land in the workspace tree. Use the existing README.md path so merge parents produce a real delete/modify conflict with git_diff3 regions. Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
Why these changesDeleted file collapsible ( Conflict deleted-side card ( Fixtures use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Side #1 deleted this file.Test plan
conflict-deleted-sides,InlineConflictCard.deleted-side, deleted-file collapsible inFileRowHeader.testtest/integration/review/deleted-file.test.tsx, delete/modify case inconflict.test.tsxscripts/screenshot/specs/review-deleted-file.spec.tsx