Skip to content

Manager: pipeline crashes randomly - #577

Merged
rssk merged 2 commits into
masterfrom
mo-loggin
Oct 3, 2018
Merged

rssk merged 2 commits into
masterfrom
mo-loggin

Conversation

@rssk

@rssk rssk commented Oct 3, 2018

Copy link
Copy Markdown
Contributor

Problem

referenced issue(s):
Closes #576

The pipeline crashes sometimes, this is due to an error in socket-stream where wrapping it in a promise causes the socket to be read to before it exits, not super sure why.
Here's the stream issue nkzawa/socket.io-stream#75

Solution

  • Fork the stream lib as it isnt being maintained really and merge that PR
  • fix docker-manager and pipeline dev builds so they at least use src from mono rep lib

Testing

  • build the UI and run several pipelines

@rssk
rssk merged commit 3655d62 into master Oct 3, 2018
@rssk
rssk deleted the mo-loggin branch October 3, 2018 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI - crashes on pipeline start intermittently

1 participant