[pull] develop from LibreBooking:develop - #583
Merged
Merged
Conversation
DocumentRoot=Web deployments that omit /Web from script.url are not supported: navigation-link validation and login/SSO redirect construction both assume /Web is present in the request path, so omitting it breaks Schedule/Calendar navigation and can break external authentication redirects (see #1590). Rather than relaxing that assumption, make the requirement explicit: - Document the /Web requirement in INSTALLATION.rst (deployment section) and BASIC-CONFIGURATION.rst (script.url setting), and add a new FAQ.rst entry referencing #1590. - Show a warning banner in globalheader.tpl when script.url is set but does not end in /Web (a trailing slash is tolerated, since ExternalAuthLoginPresenter already normalizes it that way), mirroring the existing banner shown when script.url is empty. - Add the ScriptUrlMissingWebSuffix translation string and cover the new banner logic in SmartyPageTest. Assisted-by: Claude:claude-sonnet-5 Related: #1590
Replace legacy Allow and Deny access controls with Require directives since Apache 2.4 is the minimum supported version. Simplify upload protection to a directory-wide denial while preserving the existing access policy for API methods. Update README to state Nginx is not a supported/tested web server. And that Apache >= 2.4 is required. Assisted-by: Codex:GPT-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )