[pull] develop from LibreBooking:develop - #572
Merged
Merged
Conversation
Centralize script URL suggestion generation for the install and configuration pages. Prefix non-default ports with a colon and omit the default HTTP and HTTPS ports. Add coverage for default and non-default ports, application subpaths, and conditions where no suggestion should be shown. Closes: #1555 Assisted-by: Codex:GPT-5
Use League URI to assemble suggested script URLs from their scheme, host, port, and path components. This removes manual URL concatenation and delegates port separators, default-port normalization, validation, and encoding to the URI builder. Assisted-by: Codex:GPT-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )