Skip to content

fix(@uppy/locales): repair smart_count placeholder in ja_JP folderAdded#6367

Open
greymoth-jp wants to merge 1 commit into
transloadit:mainfrom
greymoth-jp:fix-ja-folderadded-placeholder
Open

fix(@uppy/locales): repair smart_count placeholder in ja_JP folderAdded#6367
greymoth-jp wants to merge 1 commit into
transloadit:mainfrom
greymoth-jp:fix-ja-folderadded-placeholder

Conversation

@greymoth-jp

@greymoth-jp greymoth-jp commented Jun 29, 2026

Copy link
Copy Markdown

folderAdded in the Japanese locale writes the count placeholder as % {smart_count} (with a space) instead of %{smart_count}. Uppy's Translator (in @uppy/utils) builds the interpolation regex from the exact %{arg} token, so the extra space stops the substitution and the message shows the literal text % {smart_count} rather than the file count.

Every other use of the placeholder in this file is %{smart_count} (20 of them), and the en_US source is Added %{smart_count} file(s) from %{folder}. This removes the stray space in both plural forms.

@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 293c8ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant