fix(@uppy/locales): repair smart_count placeholder in ja_JP folderAdded#6367
Open
greymoth-jp wants to merge 1 commit into
Open
fix(@uppy/locales): repair smart_count placeholder in ja_JP folderAdded#6367greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
folderAddedin the Japanese locale writes the count placeholder as% {smart_count}(with a space) instead of%{smart_count}. Uppy'sTranslator(in@uppy/utils) builds the interpolation regex from the exact%{arg}token, so the extra space stops the substitution and the message shows the literal text% {smart_count}rather than the file count.Every other use of the placeholder in this file is
%{smart_count}(20 of them), and the en_US source isAdded %{smart_count} file(s) from %{folder}. This removes the stray space in both plural forms.