image handling for ollama#16
Merged
Merged
Conversation
dadmobile
requested changes
Jul 28, 2025
| for part in message["content"]: | ||
| if part.get("type") == "image_url": | ||
| if image_paths: | ||
| if image_paths and self.model_path.rsplit(".", 1)[-1] != "gguf": |
Member
There was a problem hiding this comment.
Is this condition to make things work for GGUF in general or for ollama specifically? I'm guessing it's the Ollama OpenAI API interface thing you were talking about?
Contributor
Author
There was a problem hiding this comment.
yes it's for ollama only
Member
There was a problem hiding this comment.
OK hmm...if it's for ollama then we should figure out a way to not make the check for gguf, but for ollama specifically. Maybe the ollama plugin paths some special parameter in? Like a parameter that defaults to the normal way but can be overridden?
This is all assuming we can get this to work reliably in ollama in the first place. :)
dadmobile
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.