Fix double-validation bug when using inline validates: on property in subclasses#541
Open
lucasmazza wants to merge 1 commit into
Open
Fix double-validation bug when using inline validates: on property in subclasses#541lucasmazza wants to merge 1 commit into
lucasmazza wants to merge 1 commit into
Conversation
… subclasses
When `property :name, validates: { presence: true }` is used on a form that
has subclasses, the heritage replay would call `validates` again during
subclass creation if `_inherited: true` is set in the options. This guard
skips the redundant re-registration since the `:validation` heritage entry
already handles propagating validators to subclasses.
Fixes: trailblazer/reform-rails#59
Fixes: trailblazer#323
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
property :name, validates: { presence: true }is used on a form that has subclasses, the heritage replay would callvalidatesagain during subclass creation if_inherited: trueis set in the options. This guard skips the redundant re-registration since the:validationheritage entry already handles propagating validators to subclasses.Fixes: trailblazer/reform-rails#59
Fixes: #323