Conversation
What was broken A Marathon Match submission whose scorer was stopped because the member submitted a newer solution stayed in the "Preparing" status with an empty Test Status column forever, as shown in the PM-5368 screenshots. Members had no way to tell that the run had been superseded rather than still being queued. Root cause The submission status helpers only recognized accepted and failed states, and the Test Status column only rendered IN PROGRESS, SUCCESS and FAILED. The CANCELLED test status that marathon-match-api-v6 now records was normalized away and the row fell back to the generic preparing label. What was changed - getSubmissionStatus returns a new isCancelled flag when a matching review summation reports a cancelled test run. - My Submissions list rows and the submission detail panel show a "Cancelled" status label, taking precedence over the accepted and preparing labels. - The Test Status column normalizes and renders CANCELLED using a new neutral cancelled icon, and the provisional/final score stays hidden because a cancelled run never produced a score. Any added/updated tests - __tests__/shared/utils/challenge-detail/submission-status.test.js: new case covering that a cancelled review summation reports isCancelled instead of leaving the submission in the preparing state; existing cases updated for the new flag. - __tests__/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx: new case covering that getSubmissionTestProgress surfaces a cancelled run.
…view Fix Live Preview for unpublished Thrive articles
fix: handle RecruitCRM edge errors
PM-5368: show cancelled Marathon Match scoring in My Submissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.