Feedback on README & application

[mattheworiordan]

Thanks for this @tomczoink. Great effort, it's a good bit of work you turned around quickly. I have commented inline in your code at points, but I have some additional feedback below:

• Why do you have two Git users i.e. @tomcamp333 and @tomczoink? It's a bit odd to see the commits with a mix of users.
• The screenshot of the dashboard has [?] characters for the red line, is that a bug? Would have been nice to have that as an animated GIF as well :)
• This code in README is not valid (the plus symbols are invalid):

data = {"activeUsers" : + activeUsers, 
        "browserUsers": + browserUsers,
        "iPhoneUsers" : + iPhoneUsers,
        "androidUsers": + androidUsers
};

• Generally indentation in your code is a bit inconsistent. I am not sure if this is perhaps you are using tabs and the Github presentation is messing with that.
• There's no right answer, but I would have avoided having instantaneous data on the same channel as the log messages. The reason is that channels are (relatively) cheap, but allow data to be treated differently. For example, you could load the last 10 log messages from a dedicated channel easily and populate the log automatically when the console loads. However, but mixing stats data with log messages, that's not possible because it's impossible to know how many messages to retrieve to get the last 10 log messages.

Looking forward to hearing your thoughts on my comments.

[tomczoink]

Thanks for the feedback @mattheworiordan , it's much appreciated. In regards to some of your points:

• I was logged into my other Github account accidentally it seems on my device, so that was just a mistake.

• I believe the red question marks are just the character the library uses to represent parts of the line. A GIF would have been nice I agree, good point!

• My mistake on the plus signs, it seemed to actually work in the code so it passed under my notice.

• I noticed that Github was showing my tabs in an undesirable way, so I tried to fix it from the 'Fixed some indentation issues in the code' commit. If any of the indentation doesn't match with company standard from there, I'm happy to adjust in future code.

• Good points on the channels and how they work, thanks for the information.

I'll go through your other points now, thanks a lot for the in depth feedback, it's much appreciated.

[mattheworiordan]

Thanks for a quick reply and your thoughts @tomczoink