Repository navigation
test(e2e): wait for Pierre navigation to settle - #1017
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
+ Coverage 75.61% 77.62% +2.00%
==========================================
Files 161 168 +7
Lines 23474 23616 +142
==========================================
+ Hits 17750 18331 +581
+ Misses 4314 3875 -439
Partials 1410 1410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
Recent failed runs showed nondeterministic Pierre/virtualized-list behavior rather than ordinary assertion failures:
e2efailedcomments-panel.spec.ts:146withtoBeInViewportratio 0; the same branch later passed in run 36987382541.e2e-windows (1)failed the same panel-card scroll and a navigation click timeout.Root cause and fix
Pierre virtualizes files and temporarily disables pointer events while the review list re-layouts after navigation. The affected tests asserted or clicked immediately after a scroll/navigation request. This change synchronizes with the existing
waitForScrollStableandclickWhenHittablehelpers without weakening assertions, retries, or changing production behavior.Tests
npx playwright test test/e2e/tests/comments-panel.spec.ts test/e2e/tests/comment-nav.spec.ts --project=git-mode --list: passed (40 tests discovered).npm run test:frontend: one pre-existing unrelated failure inedit-reply-font.test.jsrequiringcrit-web/assets/css/app.css; the other 644 tests passed.