Skip to content

test(e2e): wait for Pierre navigation to settle - #1017

Merged
tomasz-tomczyk merged 1 commit into
mainfrom
fix/ci-flakes-2026-10-02
Oct 3, 2026
Merged

tomasz-tomczyk merged 1 commit into
mainfrom
fix/ci-flakes-2026-10-02

Conversation

@hermes-tomczyk

Copy link
Copy Markdown
Collaborator

Summary

  • stabilize the flaky Git-mode panel-card scroll assertion by waiting for the Pierre review scroller to settle before resolving the inline card
  • use the existing hit-test-aware navigation helper for prev/next buttons so clicks are not attempted while Pierre temporarily disables pointer events during re-layout

Evidence

Recent failed runs showed nondeterministic Pierre/virtualized-list behavior rather than ordinary assertion failures:

Root cause and fix

Pierre virtualizes files and temporarily disables pointer events while the review list re-layouts after navigation. The affected tests asserted or clicked immediately after a scroll/navigation request. This change synchronizes with the existing waitForScrollStable and clickWhenHittable helpers without weakening assertions, retries, or changing production behavior.

Tests

  • Pre-commit checks: passed (gofmt, golangci-lint, Go tests, ESLint, Stylelint, CSS checks).
  • npx playwright test test/e2e/tests/comments-panel.spec.ts test/e2e/tests/comment-nav.spec.ts --project=git-mode --list: passed (40 tests discovered).
  • npm run test:frontend: one pre-existing unrelated failure in edit-reply-font.test.js requiring crit-web/assets/css/app.css; the other 644 tests passed.
  • Full browser E2E was not run locally because Go is unavailable in this macOS workspace.

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.62%. Comparing base (406875d) to head (82f7c4f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
+ Coverage   75.61%   77.62%   +2.00%     
==========================================
  Files         161      168       +7     
  Lines       23474    23616     +142     
==========================================
+ Hits        17750    18331     +581     
+ Misses       4314     3875     -439     
  Partials     1410     1410              
Flag Coverage Δ
e2e 27.02% <ø> (?)
unit 75.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tomasz-tomczyk
tomasz-tomczyk merged commit 27b495d into main Oct 3, 2026
17 checks passed
@tomasz-tomczyk
tomasz-tomczyk deleted the fix/ci-flakes-2026-10-02 branch October 3, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants