fix(web): clean up review CSS and drop stale comment jumps - #1011
Merged
Merged
Conversation
- Story file-level comments are left-aligned, matching review-list diffs since #1008. - Remove `.crit-review-file-header` side borders and radius that every render path overrode after #1004. - Share the outdated-thread layout rules with `.pierre-file-level` instead of repeating them. No visual change. - Number Pierre comment jumps so a jump replaced by a newer one stops before aligning, avoiding flicker on fast next-comment navigation. - Note why diff jumps don't wait for the list scroll to settle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 75.50% 77.51% +2.01%
==========================================
Files 161 168 +7
Lines 23403 23545 +142
==========================================
+ Hits 17671 18252 +581
+ Misses 4325 3886 -439
Partials 1407 1407
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release audit fixes for v0.21.0..main.
.file-comments) are now left-aligned at a 16px inset. Before, they were centered while review-list diffs left-align them (feat(web): left-align file-level comments in diffs #1008). Only the story view builds.file-comments. The story e2e helper now checks the alignment..crit-review-file-headerside borders and radius. After feat(web): border each file and use the code background for comment rows #1004, all three render paths (review list, story, theme preview) overrode them.top: 0stays..pierre-file-levelinstead of repeating the four layout contexts. The reviewer checked that the computed values are unchanged.No vendored renderer modules were changed, so no crit-web sync is needed. crit-web has no story mode, so nothing needs porting. The related crit-web parity fix is in tomasz-tomczyk/crit-web#435.
Test plan
npm run test:frontend(645 passed)scripts/check-css-vars.sh🤖 Generated with Claude Code