Skip to content

fix(web): clean up review CSS and drop stale comment jumps - #1011

Merged
tomasz-tomczyk merged 1 commit into
mainfrom
audit-frontend-fixes
Oct 2, 2026
Merged

tomasz-tomczyk merged 1 commit into
mainfrom
audit-frontend-fixes

Conversation

@tomasz-tomczyk

Copy link
Copy Markdown
Owner

Summary

Pre-release audit fixes for v0.21.0..main.

  • Story file-level comments (.file-comments) are now left-aligned at a 16px inset. Before, they were centered while review-list diffs left-align them (feat(web): left-align file-level comments in diffs #1008). Only the story view builds .file-comments. The story e2e helper now checks the alignment.
  • File header CSS: removed the .crit-review-file-header side borders and radius. After feat(web): border each file and use the code background for comment rows #1004, all three render paths (review list, story, theme preview) overrode them. top: 0 stays.
  • Outdated-thread CSS: the rules now share selector lists with .pierre-file-level instead of repeating the four layout contexts. The reviewer checked that the computed values are unchanged.
  • Comment jumps: each Pierre comment jump now gets a number. A jump that a newer one has replaced stops after loading, during the scroll-settle poll and before its callback. This stops the flicker on fast next-comment navigation.
  • Comment: added a note on why diff jumps don't wait for the list scroll to settle. Pierre scrolls instantly, and waiting would add at least 250ms per step.

No vendored renderer modules were changed, so no crit-web sync is needed. crit-web has no story mode, so nothing needs porting. The related crit-web parity fix is in tomasz-tomczyk/crit-web#435.

Test plan

  • npm run test:frontend (645 passed)
  • eslint, stylelint, scripts/check-css-vars.sh
  • Targeted e2e on git-mode (105 passed): pierre-settings, file-comments, comments-panel, story, comment-nav, folded-comment-nav, comment-ref-links, outdated-diff-comments, theme-preview
  • CI green

🤖 Generated with Claude Code

- Story file-level comments are left-aligned, matching review-list diffs
  since #1008.
- Remove `.crit-review-file-header` side borders and radius that every
  render path overrode after #1004.
- Share the outdated-thread layout rules with `.pierre-file-level` instead
  of repeating them. No visual change.
- Number Pierre comment jumps so a jump replaced by a newer one stops
  before aligning, avoiding flicker on fast next-comment navigation.
- Note why diff jumps don't wait for the list scroll to settle.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.51%. Comparing base (f52b934) to head (2fda4fa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
+ Coverage   75.50%   77.51%   +2.01%     
==========================================
  Files         161      168       +7     
  Lines       23403    23545     +142     
==========================================
+ Hits        17671    18252     +581     
+ Misses       4325     3886     -439     
  Partials     1407     1407              
Flag Coverage Δ
e2e 27.16% <ø> (?)
unit 75.51% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tomasz-tomczyk
tomasz-tomczyk merged commit 47ffc4c into main Oct 2, 2026
17 checks passed
@tomasz-tomczyk
tomasz-tomczyk deleted the audit-frontend-fixes branch October 2, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant