Skip to content

fix: wait for review list scroll before comment alignment - #1009

Merged
tomasz-tomczyk merged 2 commits into
mainfrom
fix/e2e-windows-stability
Oct 2, 2026
Merged

tomasz-tomczyk merged 2 commits into
mainfrom
fix/e2e-windows-stability

Conversation

@tomasz-tomczyk

Copy link
Copy Markdown
Owner

Fixes the intermittent comments-panel navigation failure in the document view. Pierre can mount a virtualized file before its smooth scroll finishes, so the comment alignment could run first and then be overwritten by the remaining file scroll. Wait for the list scroll to settle, re-resolve the mounted comment, then align it immediately.\n\nValidation:\n- Comments panel E2E suite: 25 passed\n- Failing comments-panel workflow repeated 10 times: 10 passed\n- Incremental-expand E2E suite repeated 5 times: 20 passed (no independent failure reproduced)\n- npx eslint web/app.js\n- git diff --check

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.45%. Comparing base (aa9723b) to head (ccea890).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
+ Coverage   75.42%   77.45%   +2.02%     
==========================================
  Files         161      168       +7     
  Lines       23203    23345     +142     
==========================================
+ Hits        17501    18082     +581     
+ Misses       4309     3870     -439     
  Partials     1393     1393              
Flag Coverage Δ
e2e 27.20% <ø> (?)
unit 75.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tomasz-tomczyk
tomasz-tomczyk merged commit 0fb1c60 into main Oct 2, 2026
17 checks passed
@tomasz-tomczyk
tomasz-tomczyk deleted the fix/e2e-windows-stability branch October 2, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant