Skip to content

store.max_retries configuration is ignored #82

Description

@behinddwalls

Summary

The store.max_retries configuration value is not passed to object-store backends.

Current behavior

Backend construction ignores the configured retry count. The GCS implementation uses hard-coded retry limits instead, so operators cannot tune retry behavior and the documented setting has no runtime effect.

Expected behavior

Store operations should consistently use the configured retry budget, or the unsupported option should be removed.

Suggested implementation

Pass the validated retry value into backend constructors and use it in the shared retry policy for applicable operations. Add tests that use deterministic failures to verify the configured attempt count.

Relevant code

  • crates/walgit-config/src/lib.rs:238
  • crates/walgit-store/src/lib.rs:631
  • crates/walgit-store/src/gcs.rs:33

Activity

  1. behinddwalls commented on Sep 30, 2026

    @behinddwalls
    Author

    Draft fix: #90

    This PR is part of the ordered draft stack #85 through #92.

  2. added a commit that references this issue on Oct 1, 2026
    34f240d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions