Skip to content

server.max_concurrent_requests and request_timeout are not enforced #78

Open

Description

@behinddwalls

Summary

The configured global request concurrency limit and request timeout are not applied to the server router.

Current behavior

server.max_concurrent_requests and server.request_timeout are exposed as configuration, but router construction does not install middleware that enforces either value. The middleware module documentation describes global concurrency and timeout behavior that the running server does not provide.

Expected behavior

Requests should be bounded by the configured global concurrency limit and timeout, with behavior and error responses covered by tests.

Suggested implementation

Install the appropriate concurrency and timeout layers during router construction using the validated configuration values. Add tests that saturate the global limit and exercise a timed-out handler. If these controls are not part of the intended server design, remove the inert fields and misleading documentation.

Relevant code

  • crates/walgit-config/src/lib.rs:43
  • crates/walgit-server/src/lib.rs:139
  • crates/walgit-server/src/middleware.rs:1

Activity

  1. behinddwalls commented on Sep 30, 2026

    @behinddwalls
    Author

    Draft fix: #86

    This PR is part of the ordered draft stack #85 through #92.

  2. added a commit that references this issue on Oct 1, 2026
    c7ab81a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions