Skip to content

fix(vscode): declare VS Code 1.91 so the extension packages again - #725

Merged
mostafa merged 4 commits into
mainfrom
fix/vscode-engine-1.91
Nov 19, 2026
Merged

mostafa merged 4 commits into
mainfrom
fix/vscode-engine-1.91

Conversation

@mostafa

@mostafa mostafa commented Nov 19, 2026

Copy link
Copy Markdown
Member

Stacked on #723.

Summary

  • npm run package in editors/vscode, which the editor docs tell users to run to build the VSIX, fails on main: vsce refuses an @types/vscode newer than engines.vscode, and @types/vscode has been ahead of ^1.75.0 for many releases.
  • vscode-languageclient 11 (chore(deps): bump vscode-languageclient from 10.1.2 to 11.0.0 in /editors/vscode #661) already requires VS Code ^1.91.0, so the declared ^1.75.0 was not true either. engines.vscode is now ^1.91.0 and @types/vscode is pinned to ~1.91.0. The extension type-checks against the 1.91 API, so it uses nothing newer, and from now on the compiler rejects APIs above the declared minimum.
  • Dependabot ignores minor and major @types/vscode updates for the extension, so it stops proposing versions that break packaging. The two move together by hand.
  • docs/content/editors/vscode.md states the 1.91 requirement. Since 0.27.0 already ships vscode-languageclient 11, this describes released behavior and carries no version tag.

Test plan

vsce refuses to package when @types/vscode is newer than engines.vscode, so npm run package failed. vscode-languageclient 11 already requires VS Code 1.91, which makes the old ^1.75.0 engine inaccurate too. Declare ^1.91.0, pin @types/vscode to ~1.91.0 so the compiler rejects newer APIs, and update the editor docs.
Base automatically changed from fix/dependency-updates-mid-nov-2026 to main November 19, 2026 17:43
@mostafa
mostafa merged commit 6d631c8 into main Nov 19, 2026
37 of 39 checks passed
@mostafa
mostafa deleted the fix/vscode-engine-1.91 branch November 19, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant