Repository navigation
fix(vscode): declare VS Code 1.91 so the extension packages again - #725
Merged
Merged
Conversation
vsce refuses to package when @types/vscode is newer than engines.vscode, so npm run package failed. vscode-languageclient 11 already requires VS Code 1.91, which makes the old ^1.75.0 engine inaccurate too. Declare ^1.91.0, pin @types/vscode to ~1.91.0 so the compiler rejects newer APIs, and update the editor docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #723.
Summary
npm run packageineditors/vscode, which the editor docs tell users to run to build the VSIX, fails onmain:vscerefuses an@types/vscodenewer thanengines.vscode, and@types/vscodehas been ahead of^1.75.0for many releases.vscode-languageclient11 (chore(deps): bump vscode-languageclient from 10.1.2 to 11.0.0 in /editors/vscode #661) already requires VS Code^1.91.0, so the declared^1.75.0was not true either.engines.vscodeis now^1.91.0and@types/vscodeis pinned to~1.91.0. The extension type-checks against the 1.91 API, so it uses nothing newer, and from now on the compiler rejects APIs above the declared minimum.@types/vscodeupdates for the extension, so it stops proposing versions that break packaging. The two move together by hand.docs/content/editors/vscode.mdstates the 1.91 requirement. Since 0.27.0 already shipsvscode-languageclient11, this describes released behavior and carries no version tag.Test plan
npm ci,npm run compile,tsc --noEmit, andnpm auditineditors/vscodevsce packageproduces the VSIX (it fails onmainand on chore(deps): batch dependency updates (mid Nov 2026) #723)npm run docs:buildandnpm run docs:validate