Skip to content

Refactor oura setup in auth and data services#950

Open
darinkrauss wants to merge 1 commit into
darin/refactor-oura-eventsfrom
darin/refactor-oura-setup
Open

Refactor oura setup in auth and data services#950
darinkrauss wants to merge 1 commit into
darin/refactor-oura-eventsfrom
darin/refactor-oura-setup

Conversation

@darinkrauss
Copy link
Copy Markdown
Contributor

  • Refactor oura setup in auth and data services
  • Directly create work processor factors without wrapper
  • Allow Customerio as optional
  • Update Jotform and Shopify processor types for consistency

- Refactor oura setup in auth and data services
- Directly create work processor factors without wrapper
- Allow Customerio as optional
- Update Jotform and Shopify processor types for consistency
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors how Oura-related and notifications work processors/singletons are wired up in the auth and data services by removing the intermediate “processors” wrapper packages and registering processor factories directly in the services. It also standardizes Oura work type strings for Jotform/Shopify reconcile and makes Customer.io event sending a no-op when Customer.io isn’t configured.

Changes:

  • Remove oura/work/processors and notifications/work/processors wrapper packages (and their tests) and move processor-factory registration into the services.
  • Add explicit work singletons initialization in services and switch Jotform/Shopify reconcile helpers to NewWorkCreate().
  • Add a Customer.io enabled() helper and skip SendEvent when keys are not configured.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
oura/work/processors/processors.go Deleted wrapper for building Oura processor factories and ensuring singleton work.
oura/work/processors/processors_test.go Removed tests for the deleted Oura processors wrapper.
oura/work/processors/processors_suite_test.go Removed suite for the deleted Oura processors wrapper.
oura/shopify/work/reconcile.go Standardizes work Type and replaces singleton creation helper with NewWorkCreate().
oura/jotform/work/reconcile.go Standardizes work Type, adds NewWorkCreate(), and tweaks logging field attachment.
notifications/work/processors/processors.go Deleted wrapper for building notifications processor factories.
notifications/work/processors/processors_test.go Removed tests for the deleted notifications processors wrapper.
notifications/work/processors/processors_suite_test.go Removed suite for the deleted notifications processors wrapper.
data/service/service/standard.go Registers processor factories directly and creates singleton work items during coordinator init.
customerio/event.go Adds logging context and skips sending events when the client is not enabled.
customerio/client.go Adds enabled() helper to detect missing Customer.io keys.
auth/service/service/service.go Refactors work coordinator setup to register factories directly and create singleton work items via NewWorkCreate().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread data/service/service/standard.go
Comment thread oura/jotform/work/reconcile.go
Comment thread oura/shopify/work/reconcile.go
Comment thread customerio/client.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants