Repository navigation
Add support for React 18+ #242
Description
Activity
I'm unable to fix few issues. It also doesn't look like the package is maintained.
OK, I'll need to upgrade rc-tabs to latest.
@adityatoshniwal the problem is that antd has performance issue, I'm waiting for antd6 before having any major change.
also rc-dock doesn't work with Strict Mode, if you disable strict mode it should work.
@adityatoshniwal the problem is that antd has performance issue, I'm waiting for antd6 before having any major change.
also rc-dock doesn't work with Strict Mode, if you disable strict mode it should work.
Hi @rinick,
I was working on upgrading the rc-tabs package version. That's the only package (v11) which is not React 19 compatible I guess. Should I stop?
@adityatoshniwal actually, I'm working on that right now, I will see what I need to do to support react 18 and 19.
so yes, maybe you should stop, I will reply in this ticket once there is any update@adityatoshniwal actually, I'm working on that right now, I will see what I need to do to support react 18 and 19. so yes, maybe you should stop, I will reply in this ticket once there is any update
@rinick There is no issue with functioning but I get an error for https://react.dev/blog/2024/04/25/react-19-upgrade-guide#new-deprecations because of rc-tabs.
@adityatoshniwal I see a lot of
Accessing element.ref was removed in React 19. ref is now a regular prop. It will be removed from the JSX Element type in a future release.But can't find a good way to resolve it.latest version of rc-tabs has too many breaking changes,
I have a fork of rc-tabs here: https://github.com/ticlo/rc-tabs, if you know what's causing the issue you can also open your PR there.
Reacted by Aditya ToshniwalI tried to update the react version but unfortunately this rc-tabs will require many sub packages to be updated, best path would be I think is use the latest rc-tabs and make the changes accordingly in rc-dock.
@adityatoshniwal rc-components are maintained by the same team as ant design. I think they will officially support react 19 at antd v6.
so any effort to support react 19 before antd6 release would be a waste of time,@adityatoshniwal rc-components are maintained by the same team as ant design. I think they will officially support react 19 at antd v6. so any effort to support react 19 before antd6 release would be a waste of time,
Got it. When do you think antd6 will be released?
@adityatoshniwal
they announced it here: ant-design/ant-design#52115
from previous experience, 6 months after that they will have beta version and then 3 months later they will have a release.
So there should be a beta version soonHi @rinick,
Can't we also create an alpha version for rc-dock based on alpha antd 6?Hi @rinick, Can't we also create an alpha version for rc-dock based on alpha antd 6?
@rinick Can we create a beta for rc-dock based on https://www.npmjs.com/package/antd/v/6.0.0-alpha.2? That way we'll be ready.
@rinick Antd 6 is released.
Hi,
I'm working on adding support for React 18+ (including 19). I hope my PR will be accepted.