Repository navigation
Conversation
…enable CallBack conformance tests Update HIIConfigAccess.h for UEFI 2.8 (Mantis 1956): - Add EFI_BROWSER_ACTION_REQUEST_FORM_SUBMIT_EXIT through EFI_BROWSER_ACTION_REQUEST_RECONNECT (values 4-8) and EFI_BROWSER_ACTION_REQUEST_QUESTION_APPLY (9) - Add proper EFI_BROWSER_ACTION_* defines (CHANGING through SUBMITTED) - Fix CallBack() Action parameter type from pointer to value per spec - Fix CallBack() Value parameter to IN OUT per spec - Fix double semicolon in struct forward declaration Enable previously-disabled CallBack() conformance tests: - Checkpoint 1: NULL ActionRequest returns EFI_INVALID_PARAMETER - Checkpoint 2: NULL Value returns EFI_INVALID_PARAMETER - Checkpoint 3: Unsupported action returns EFI_UNSUPPORTED Fix EFI_BROWSER_ACTION_UNSUPPORTED value from 2 to 0xFFFF since value 2 is now EFI_BROWSER_ACTION_RETRIEVE in UEFI 2.1+. Remove buggy ActionRequest validation that used C logical-OR (||) instead of proper value comparison. Cc: G Edhaya Chandran <edhaya.chandran@arm.com> Cc: Barton Gao <gaojie@byosoft.com.cn> Signed-off-by: Chris Gjertsen <chris@gjertsen.dev>
tianocore-assign-reviewers
Bot
requested review from
anncheng-arm,
edhay,
shellyki-intel and
sunnywang-arm
May 1, 2026 21:14
Contributor
|
Do we need to port these changes to IHVSCT (uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/HIIConfigAccess) as well ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…enable CallBack conformance tests
Update HIIConfigAccess.h for UEFI 2.8 (Mantis 1956):
Enable previously-disabled CallBack() conformance tests:
Fix EFI_BROWSER_ACTION_UNSUPPORTED value from 2 to 0xFFFF since value 2 is now EFI_BROWSER_ACTION_RETRIEVE in UEFI 2.1+.
Remove buggy ActionRequest validation that used C logical-OR (||) instead of proper value comparison.
Cc: G Edhaya Chandran edhaya.chandran@arm.com
Cc: Barton Gao gaojie@byosoft.com.cn