Repository navigation
Conversation
…s 2359) UEFI 2.10A (Mantis 2359) updated EFI_ATA_PASS_THRU_PROTOCOL to clarify that when a port multiplier is not connected, GetNextDevice() may either return EFI_SUCCESS with PortMultiplierPort set to 0xFFFF, or return EFI_NOT_FOUND (in which case PortMultiplierPort is undefined). The existing tests only accepted EFI_NOT_FOUND as a valid terminal condition, causing false failures on implementations that return EFI_SUCCESS + 0xFFFF. Changes: - AtaPassThruBBTestFunction.c: Update BBTestGetNextDeviceFunctionAutoTest to accept both EFI_NOT_FOUND and EFI_SUCCESS with PortMultiplierPort == 0xFFFF as passing conditions after device enumeration - AtaPassThruBBTestConformance.c: Update BBTestGetNextDeviceConformance checkpoint 1 and 2 to gracefully skip (WARNING) instead of fail when GetNextDevice returns EFI_NOT_FOUND due to no port multiplier connected Ref: tianocore#341 Signed-off-by: Carolyn Gjertsen <cgjertsen@gmail.com>
tianocore-assign-reviewers
Bot
requested review from
anncheng-arm,
edhay,
shellyki-intel and
sunnywang-arm
April 28, 2026 15:48
cgjertsen
added a commit
to cgjertsen/edk2-test
that referenced
this pull request
May 14, 2026
Add 2025.05 revision history entry covering UEFI 2.8–2.10A test updates (PRs tianocore#320, tianocore#346–tianocore#352). Register new chapters 33 (REST EX Protocol) and 34 (Redfish Discover Protocol) in the Sphinx table of contents. Cc: PR tianocore#320, PR tianocore#346, PR tianocore#347, PR tianocore#348, PR tianocore#349, PR tianocore#350, PR tianocore#351, PR tianocore#352 Signed-off-by: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s 2359)
UEFI 2.10A (Mantis 2359) updated EFI_ATA_PASS_THRU_PROTOCOL to clarify that when a port multiplier is not connected, GetNextDevice() may either return EFI_SUCCESS with PortMultiplierPort set to 0xFFFF, or return EFI_NOT_FOUND (in which case PortMultiplierPort is undefined).
The existing tests only accepted EFI_NOT_FOUND as a valid terminal condition, causing false failures on implementations that return EFI_SUCCESS + 0xFFFF.
Changes:
Ref: #341