Repository navigation
[New Test Coverage] SctPkg/RedfishDiscoverBBTest: Add EFI_REDFISH_DISCOVER_PROTOCOL black-box tests (Mantis 1920, 1925, 2172) - #348
Open
cgjertsen wants to merge 1 commit into
Conversation
tianocore-assign-reviewers
Bot
requested review from
anncheng-arm,
edhay,
shellyki-intel and
sunnywang-arm
April 21, 2026 20:30
Update Redfish Discover black-box tests to align with UEFI 2.8C (Mantis 2172) revised protocol definitions. New conformance checkpoints: - AcquireRedfishService() with Flags == EFI_REDFISH_DISCOVER_VALIDATION only (VALIDATION is a modifier, not a discovery method; implementation masks it out before checking Flags == 0) - GetNetworkInterfaceList() with NULL ImageHandle - AcquireRedfishService() with NULL ImageHandle Update spec references in file headers and protocol header to cite Mantis 2172. Ref: tianocore#324 Signed-off-by: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
cgjertsen
force-pushed
the
redfish-discover-mantis-2172
branch
from
April 21, 2026 20:40
88e48be to
5e3c0be
Compare
cgjertsen
added a commit
to cgjertsen/edk2-test
that referenced
this pull request
May 14, 2026
Add 2025.05 revision history entry covering UEFI 2.8–2.10A test updates (PRs tianocore#320, tianocore#346–tianocore#352). Register new chapters 33 (REST EX Protocol) and 34 (Redfish Discover Protocol) in the Sphinx table of contents. Cc: PR tianocore#320, PR tianocore#346, PR tianocore#347, PR tianocore#348, PR tianocore#349, PR tianocore#350, PR tianocore#351, PR tianocore#352 Signed-off-by: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add new black-box test module for EFI_REDFISH_DISCOVER_PROTOCOL covering all four protocol functions introduced in UEFI 2.8 (Mantis 1920), with clarifications from Mantis 1925 and revised definitions from UEFI 2.8C (Mantis 2172).
Function tests:
GetNetworkInterfaceList() — valid call and interface count consistency
AcquireRedfishService() — synchronous discovery via host interface
AbortAcquireRedfishService() — basic abort with NULL target
ReleaseRedfishService() — release with empty list
Conformance tests:
GetNetworkInterfaceList() with NULL NumberOfNetworkInterfaces, NULL NetworkInterfaces, and NULL ImageHandle
AcquireRedfishService() with NULL Token, Flags == 0, VALIDATION-only flags, and NULL ImageHandle
ReleaseRedfishService() with NULL List
Per Mantis 2172, the EFI_REDFISH_DISCOVER_VALIDATION flag is a modifier rather than a discovery method — setting it alone is treated as Flags == 0 and returns EFI_INVALID_PARAMETER.
Test plan
Builds cleanly with GCC toolchain for X64 (requires fix-efi-h-tiano-pragma-once for Efi.h compat)
Verify conformance tests pass on platform with Redfish Discover protocol installed
Verify function tests produce WARNING (not FAIL) on platforms without a Redfish service
Ref: #323, #324