Repository navigation
Conversation
tianocore-assign-reviewers
Bot
requested review from
anncheng-arm,
edhay,
shellyki-intel and
sunnywang-arm
April 21, 2026 14:33
cgjertsen
force-pushed
the
restex-async-send-receive-mantis-1924
branch
3 times, most recently
from
April 21, 2026 19:40
b7d0a85 to
c532ed2
Compare
Add comprehensive black-box tests for EFI_REST_EX_PROTOCOL per UEFI 2.8 (Mantis 1834) with conformance clarifications from Mantis 1879. New test coverage for all seven protocol functions: - GetService(): Function and conformance (NULL parameter) - Configure(): Function (reset to unconfigured) and conformance - GetModeData(): Function and conformance (NULL parameter, not-ready) - SendReceive(): Function (basic GET) and conformance (NULL parameters, not-ready before Configure) - GetServiceTime(): Function and conformance (NULL Time, not-ready) - AyncSendReceive(): Function and conformance (NULL token, not-ready) - EventService(): Function and conformance (NULL token, not-ready) Per Mantis 1879 clarification, all conformance tests verify that functions except GetService() return EFI_NOT_READY when Configure() has not been called. Ref: tianocore#321 Signed-off-by: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
cgjertsen
force-pushed
the
restex-async-send-receive-mantis-1924
branch
2 times, most recently
from
April 21, 2026 20:15
02462c6 to
8b3c64d
Compare
Add test checkpoints for the UEFI 2.8 (Mantis 1924) updates to EFI_REST_EX_PROTOCOL.AsyncSendReceive(): Conformance tests: - Checkpoint 3: NULL RequestMessage cancels async request, expects EFI_ABORTED per revised cancellation semantics - Checkpoint 4: Zero TimeOutInMilliSeconds expects EFI_TIMEOUT per revised timeout handling Function tests: - Checkpoint 2: Non-NULL TimeOutInMilliSeconds validates timeout path - Checkpoint 3: NULL RequestMessage cancellation returns EFI_ABORTED Also fix duplicate WARNING branches in SendReceive, AyncSendReceive, and EventService function tests (should be FAILED for unexpected status codes). Ref: tianocore#322 Signed-off-by: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
cgjertsen
force-pushed
the
restex-async-send-receive-mantis-1924
branch
from
May 6, 2026 22:42
8b3c64d to
5cbdbb0
Compare
cgjertsen
added a commit
to cgjertsen/edk2-test
that referenced
this pull request
May 14, 2026
Add 2025.05 revision history entry covering UEFI 2.8–2.10A test updates (PRs tianocore#320, tianocore#346–tianocore#352). Register new chapters 33 (REST EX Protocol) and 34 (Redfish Discover Protocol) in the Sphinx table of contents. Cc: PR tianocore#320, PR tianocore#346, PR tianocore#347, PR tianocore#348, PR tianocore#349, PR tianocore#350, PR tianocore#351, PR tianocore#352 Signed-off-by: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
EFI_REST_EX_PROTOCOL.AsyncSendReceive()black-box tests to cover the revised asynchronous operation semantics introduced by UEFI 2.8 (Mantis 1924).Changes
Conformance tests (
RestExBBTestConformance.c):RequestMessage— expectsEFI_ABORTEDper the revised cancellation semanticsTimeOutInMilliSeconds— expectsEFI_TIMEOUTper the revised timeout handlingFunction tests (
RestExBBTestFunction.c):TimeOutInMilliSecondsexercises the timeout pathRequestMessagecancellation returnsEFI_ABORTEDBug fixes:
EFI_TEST_ASSERTION_WARNINGin else branches forSendReceive,AyncSendReceive, andEventServicefunction tests (should beEFI_TEST_ASSERTION_FAILEDfor unexpected status codes)New Assertion GUIDs
014(NULL RequestMessage cancellation),015(zero timeout)010(timeout parameter),011(NULL RequestMessage cancellation)Specification Reference
Test Plan
RestExBBTest.inf)Closes #322