manager: guard parseKernelVersion against non-Int version fields - #3593
Open
palazik wants to merge 1 commit into
Open
manager: guard parseKernelVersion against non-Int version fields#3593palazik wants to merge 1 commit into
palazik wants to merge 1 commit into
Conversation
parseKernelVersion fed each regex group straight into toInt(). The groups come from uname().release, and a field that doesn't fit in an Int throws NumberFormatException, which is an uncaught crash rather than the (-1,-1,-1) sentinel the function already uses for "couldn't parse". Use toIntOrNull() and fall back to the sentinel if any field overflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseKernelVersionpulls three numeric groups out of the version string and calls.toInt()on each:The input is
Os.uname().release, which isn't guaranteed to be sane. If any captured field is longer thanInt.MAX_VALUEcan hold,toInt()throwsNumberFormatExceptionand takes the app down, even though the function already has a(-1, -1, -1)sentinel for the "no match" case.Switched to
toIntOrNull()and fall back to that same sentinel when a field can't be parsed, so a strange release string just reads as an unknown version instead of crashing.