Feat/migrate new dart client

[deaflynx]

Summary

Migrates the app from the hand-written thingsboard_client 4.2.1 to the autogenerated thingsboard_ce_client 4.4.0. The data-access layer is rebuilt on the generated client while the auth/session/storage/websocket runtime is preserved.

Key changes

• Service → controller APIs: semantic services (getAlarmService(), getDeviceService(), …) replaced by generated per-controller APIs (getAlarmControllerApi(), getDeviceControllerApi(), …); responses are now Dio Response<T> and are unwrapped via .data.
• Immutable models: generated built_value models with all-nullable fields replace the old mutable models; call sites updated for the Builder pattern, defensive null handling, and enum unknownDefaultOpenApi fallbacks.
• Type/shape renames and query-object → flat-parameter changes across alarms, entities, auth/2FA, routes and themes.
• Vendored client-side helpers (e.g. AlarmCommentJsonNode access, platform-version helpers) restored on the app side via extensions.

Review fixes (commit a5397f1)

Addresses the code-review findings on this PR plus a few related regressions found alongside:

• Device claiming reports success only on a non-failure claim response (was unconditional).
• commentNode made nullable to avoid an NPE on system-generated alarm activity.
• Account deletion now bridges the built_value Authority to the hand-written enum (the comparisons were previously always false → dead code).
• 2FA: no duplicate global error overlay on 429, and a null JWT token is surfaced rather than masked.
• noauth QR login: timeouts, null-safe parsing, clear error on a missing token.
• Asset details navigation fixed to match the /asset/:id route.

Testing

Manual verification of the migrated flows is in progress — priority on device claiming (response contract), 2FA 429 handling, and noauth QR edge cases.

[deaflynx]

Code review

Found 3 issues:

1. Device claim now reports success even when the server rejects the claim. The migration dropped RequestConfig(ignoreErrors: true) and the if (response.response == ClaimResponse.CLAIMED || SUCCESS) {...} else { emit error } check. The new code fires DeviceProvisioningStatus.done unconditionally whenever the call doesn't throw, so an HTTP 200 with a failure body (e.g. FAILURE, CLAIMED_BY_ANOTHER_USER) is silently treated as success. This regresses the error path maintained in 95621cb.

flutter_thingsboard_app/lib/modules/device/provisioning/bloc/device_provisioning_bloc.dart

Lines 110 to 124 in 19ca50c

	.getDeviceControllerApi()
	.claimDevice(
	deviceName: deviceName,
	claimRequest: ClaimRequest((b) => b..secretKey = deviceSecretKey),
	)
	.timeout(
	const Duration(seconds: 20),
	onTimeout:
	() => throw Exception('Device claiming timeout reached'),
	);
	communicationService.fire(
	const DeviceProvisioningStatusChangedEvent(
	DeviceProvisioningStatus.done,
	),

2. commentNode force-unwraps a nullable comment, crashing on system alarm activities. comment is JsonObject? and system-generated activity entries (acks, clears, status changes) have comment == null. SystemActivityWidget calls .commentNode on exactly those entries, so comment! throws "Null check operator used on a null value". This is the same crash class fixed and re-applied in a639cab / 245c362; the guard is now gone.

flutter_thingsboard_app/lib/thingsboard_client_extensions.dart

Lines 10 to 13 in 19ca50c

	extension AlarmCommentInfoExt on AlarmCommentInfo {
	AlarmCommentJsonNode get commentNode =>
	AlarmCommentJsonNode.fromJson(comment!.asMap.cast<String, dynamic>());
	}

3. Asset details navigation is broken by a route path mismatch. The asset details route was moved from a nested child of /assets (full path /assets/asset/:id) to a top-level route with path /asset/:id, but the call site still navigates to /assets/asset/..., which no longer matches — the details page will not open. (The move also drops parentNavigatorKey: globalNavigatorKey, unlike every other details route, so the bottom nav bar would overlay the page.)

flutter_thingsboard_app/lib/config/routes/v2/routes_config/routes/asset_routes.dart

Lines 19 to 25 in 19ca50c

	GoRoute(
	path: '${AssetRoutes.asset}/:id',
	builder: (context, state) {
	final id = state.pathParameters['id']!;
	return AssetDetailsPage(id);
	},

flutter_thingsboard_app/lib/modules/asset/assets_base.dart

Lines 46 to 48 in 19ca50c

	if (asset.id?.id != null) {
	getIt<ThingsboardAppRouter>().navigateTo('/assets/asset/${asset.id!.id}');
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[deaflynx]

Addressed in a5397f1.

1. Device claim false success — no longer fires done unconditionally. _isClaimFailure inspects the claim response and reports success only when the body isn't an explicit non-success result (empty / CLAIMED / SUCCESS count as success).

flutter_thingsboard_app/lib/modules/device/provisioning/bloc/device_provisioning_bloc.dart

Lines 127 to 137 in a5397f1

	// body (e.g. the CLAIMED case) is still considered success.
	if (_isClaimFailure(response.data)) {
	emit(const DeviceProvisioningClaimingErrorState(null));
	return;
	}
	communicationService.fire(
	const DeviceProvisioningStatusChangedEvent(
	DeviceProvisioningStatus.done,
	),
	);

2. commentNode NPE on system activity — commentNode now returns AlarmCommentJsonNode?; all three call sites use ?., so system-generated entries with a null comment no longer crash.

flutter_thingsboard_app/lib/thingsboard_client_extensions.dart

Lines 10 to 18 in a5397f1

	extension AlarmCommentInfoExt on AlarmCommentInfo {
	/// `comment` is nullable on the new built_value model, and system-generated
	/// activity entries may not carry a payload, so callers must handle null.
	AlarmCommentJsonNode? get commentNode {
	final raw = comment?.asMap;
	if (raw == null) return null;
	return AlarmCommentJsonNode.fromJson(raw.cast<String, dynamic>());
	}
	}

3. Asset details route mismatch — call site now navigates to /asset/:id to match the route.

flutter_thingsboard_app/lib/modules/asset/assets_base.dart

Lines 44 to 48 in a5397f1

	@override
	void onEntityTap(AssetInfo asset, WidgetRef ref) {
	if (asset.id?.id != null) {
	getIt<ThingsboardAppRouter>().navigateTo('/asset/${asset.id!.id}');
	}

(Left parentNavigatorKey as-is — the device detail route and PE both omit it; will revisit if the bottom nav overlays the page during testing.)

Also fixed while in these files:

• Account deletion was dead code — user.authority (built_value enum) was compared against the hand-written Authority enum the barrel re-exports, so both delete branches were unreachable. Bridged via authorityFromString(user.authority.name).
• 2FA — suppressed the duplicate global error overlay on 429 (extra: {'ignoreErrors': true}) and guard a null JWT token instead of masking it with ?? ''.
• noauth QR login — added connect/receive timeouts, null-safe response parsing, and a clear error when the target host returns no token.