audio: module_adapter: fix sizeof(pointer) and underflow in module_ext_init_decode

[tmleman]

Three weaknesses compose into a single chain in module_ext_init_decode() that allows a crafted IPC4 ModuleInit payload to corrupt spec->size and spec->data before they are consumed by module_adapter_init_data().

The size guard used the wrong sizeof operand:

if (spec->size < sizeof(ext_init)) /* sizeof(pointer) = 4, not 12 */

This accepted any payload >= 4 bytes even though the struct header is 12 bytes. Additionally, ext_init->data_obj_array was dereferenced before the guard ran, allowing the object-walk loop to be skipped with no size validation. When the loop is skipped, the unconditional spec->size adjustment:

spec->size -= (unsigned char )obj - spec->data; / obj = data + 12 */

produces an unsigned underflow for spec->size in [4, 11], yielding values around 0xFFFFFFFC. The corrupted spec is then passed to module_adapter_init_data() where the inflated size bypasses the base_cfg guard and dst->base_cfg is populated from mailbox bytes beyond the declared payload boundary.

Found by semgrep static analysis, confirmed by manual review of the caller chain through module_adapter_init_data(), and verified with prepared tests.

Fixes:

1. Move size guard before ext_init dereference so spec->size is validated against sizeof(*ext_init) before any field is read.

2. Correct sizeof operand from sizeof(ext_init) to sizeof(*ext_init) (4 bytes → 12 bytes).

3. Guard the unconditional spec adjustment — compute consumed bytes and return -EINVAL if consumed > spec->size before subtracting.

4. Add upper-bound check in module_adapter_init_data() — reject cfgsz greater than MAILBOX_HOSTBOX_SIZE as a defense-in-depth measure.

[Copilot]

Pull request overview

Fixes a vulnerability chain in IPC4 module extended-init decoding that could underflow spec->size and allow out-of-bounds mailbox reads during module adapter initialization.

Changes:

• Validate spec->size against the full ext_init header (sizeof(*ext_init)) before dereferencing any fields.
• Prevent unsigned underflow by checking the computed consumed-byte count before adjusting spec->size.
• Add a defense-in-depth upper bound in module_adapter_init_data() to reject configs larger than MAILBOX_HOSTBOX_SIZE.

[jsarha]

Good caught. The copilot comment is valid, but not that critical (and the error is probably copypasted from my earlier print, feel free fix that too if you get to it).

[lgirdwood]

LGTM, we just need the comment/assertion once aligned.

[lgirdwood]

@tmleman a build failure for testbench, looks like we are missing a header ?

/home/runner/work/sof/sof/sof/src/audio/module_adapter/module_adapter_ipc4.c: In function ‘module_ext_init_decode’:
/home/runner/work/sof/sof/sof/src/audio/module_adapter/module_adapter_ipc4.c:119:9: error: implicit declaration of function ‘__ASSERT’ [-Werror=implicit-function-declaration]
  119 |         __ASSERT(consumed <= spec->size, "ext_init consumed %zu > spec->size %u",
      |         ^~~~~~~~
cc1: all warnings being treated as errors

[softwarecki]

Good catch!