Fixes #39537 - Implement LDAP CA cert support - #658
Merged
Conversation
adamlazik1
marked this pull request as draft
July 17, 2026 13:18
adamlazik1
force-pushed
the
ldap-cacert
branch
5 times, most recently
from
July 17, 2026 17:28
8da0f9a to
c079aee
Compare
Cacert can be provided as file or string. Made with Cursor.
adamruzicka
reviewed
Jul 20, 2026
adamruzicka
reviewed
Jul 21, 2026
adamruzicka
left a comment
adamruzicka
left a comment
Contributor
There was a problem hiding this comment.
Will need to test this, but at a glance it looks good.
Contributor
Author
|
For now, I tested it with theforeman/foreman#11107. |
|
ACK as per theforeman/foreman#11107 (comment) I've used a packit build in all scenarios since Hammer is not containerized |
Contributor
|
We can undraft now |
adamruzicka
approved these changes
Aug 4, 2026
adamlazik1
marked this pull request as ready for review
August 4, 2026 08:25
Contributor
|
Thank you @adamlazik1 & @lhellebr ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cacert can be provided as file or string.
Made with Cursor.
Requires theforeman/foreman#11107