Repository navigation
add "nogloss" Liquid tag to prevent glossary popups from being rendered - #193
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in the haskell3 chapter, there were many usages of the word "alternative" in prose. These usages were erroneously causing glossary popups to be rendered - phrases like "here is an alternative".
This PR provides a means of fixing this. I added a new Liquid tag, which can be used in Markdown files to prevent glossary popups from being rendered when they otherwise would be.
For example,
<% nogloss Parser %>would prevent the glossary popup being rendered for the "Parser" string.I also went through the haskell3 chapter and added this tag in the relevant spots I found.
It'd be possible to do the same thing by just wrapping problematic usages in spans, but I thought this would be simpler for authoring.