Skip to content

Spammy console.log of NaN in descent.ts #352

Description

@andoppomny

The following from descent.ts:

                    if (!isFinite(gs))
                        console.log(gs);

sometimes causes an excessive amount of console logging of NaN for me, causing me to have to kill the browser tab.
Probably there shouldn't be log statements in this library, but if there has to be, they should have helpful messages. Could it throw an exception instead?

I'm using cytoscape.js with the cytoscape-cola plugin. I use Vite dev server, and the problem seems to be triggered sometimes after a hot reload. So I'm not considering this a true bug in webcola, just a situation that shouldn't arise that isn't handled well.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions