Repository navigation
fix[notask]: integrate tiled-image geometry and resize rounding fixes - #5489
DmitryMalishev wants to merge 17 commits into
Conversation
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
Signed-off-by: Dmitry Malishev <dmitry.malishev@tether.io>
Signed-off-by: Dmitry Malishev <dmitry.malishev@tether.io>
Signed-off-by: Dmitry Malishev <dmitry.malishev@tether.io>
…m-media-runtime-validation
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
[Medium impact] No blocking code issue was found; keep the stated validation and official-dependency merge gates. SummaryThis PR connects the tiled-image geometry and resize fixes through a temporary Fabric overlay.
No actionable new issues were found. The previous and current heads have different merge bases with the supplied target, so this review covered the full PR diff. Reviews (4) · Last reviewed commit: "fix: preserve current Fabric port runtim..." · Reviewed by Greptile |
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
Task: QVAC-27614
🎯 What problem does this PR solve?
📝 How does it solve it?
packages/fabricvcpkg overlay to Fabric4fe4ded8519d4ce4ce241fe6b73594545253025e, with a verified source SHA-512.🧪 How was it tested?
32472534aincludes main69a8cd98c. LLM JavaScript unit tests, fixture/helper tests, mobile configuration validators, lint, type checks and consumer type checks passed locally; lint reports three existingrequire-awaitwarnings.2b6c46f47: all nine Fabric prebuilds and consumer smoke checks passed. All LLM C++/desktop integration checks and the CPU-only translation rows passed. Seven embedding integration jobs failed before model loading because the original fixture URL returned HTTP 401; their logs show only the old staging list. This is a confirmed external fixture failure, independent of the native fixes.4fe4ded85passed all three mtmd test targets, 100 sequential server requests, 14 batched controls, four CPU grid cases, two resize-boundary requests, 14 addon assertions and 13 SDK stop-reason requests. These predate the refreshed packaging recipe and do not replace its current CI.Known CI exception
The unchanged sharded embedding test fails at its original HF download URL (HTTP 401). A separate repair is in progress. This PR neither suppresses that test nor changes its assertions or CI labels; the exception is limited to this confirmed fixture failure.
Merge prerequisites
AI assistance: Codex assisted implementation and validation; manual review is required.