Repository navigation
mtmd: preserve tiled chunk geometry and reference resize rounding - #457
Merged
Merged
Conversation
iancris
approved these changes
Nov 3, 2026
DmitryMalishev
force-pushed
the
codex/mtmd-grid-rounding-release
branch
from
November 3, 2026 12:57
4fe4ded to
c3edc86
Compare
yingying0906
approved these changes
Nov 3, 2026
Assisted-by: Codex
Assisted-by: Codex
DmitryMalishev
force-pushed
the
codex/mtmd-grid-rounding-release
branch
from
November 3, 2026 13:48
c3edc86 to
9715925
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: QVAC-27614
🎯 What problem does this PR solve?
grid_x/grid_y. Some valid Qwen-style multi-grid images then have incorrect token counts and decoder positions, causing HTTP 500 / invalid input batch failures. Runtime/addon PR #5489 integrates this engine fix through the shared Fabric package.📝 How does it solve it?
temp-11739(upstream b11739 integration), rebased directly onto base14ecfda0c(merged ci : drop duplicate permissions block in pre-tokenizer-hashes #480). After this merges, publish the updated vcpkg port and replace the temporary overlay in QVAC #5489 with its official dependency before merging that integration PR. Public model/addon APIs are unchanged.🧪 How was it tested?
97159252eis rebased directly ontotemp-11739at14ecfda0c, including #480. Only five mtmd implementation/test files differ from the base.git diff --checkpassed.c3edc86c2; the mtmd implementation and regression files are identical. That verified source passed all three focused mtmd targets under ASan+UBSan with leak detection and halt-on-error; cache tests reject versions 2 and 3.4fe4ded85passed 100 sequential GPU requests, 14 batched controls, four CPU grid cases, two resize-boundary requests, slot restore and stale-cache rejection. Those results and the old addon overlay do not certify the new base. SDK stop-reason PR server : fix system prompt cli ggml-org/llama.cpp#5516 remains independent.💥 Breaking Changes
AI assistance: Codex assisted implementation and validation; human maintainer review is required.