Repository navigation
docs: clarify save vs save_weights for TFQ models - #1115
Open
akhil9tiet wants to merge 2 commits into
Open
akhil9tiet wants to merge 2 commits into
akhil9tiet wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the docs/concepts.md documentation by replacing curly apostrophes with straight apostrophes, updating a link for 'Quantum convolutional neural networks' to point to an arXiv paper, and adding a new 'Saving models' section that explains how to save and load TensorFlow Quantum models using weights serialization. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #899
Adds a short note to docs/concepts.md clarifying that model.save() does not work for TFQ models with custom quantum layers, and that model.save_weights() should be used instead (with the model architecture rebuilt in Python before loading).