Repository navigation
Conversation
THardy98
force-pushed
the
review/sticky-activity-polling
branch
3 times, most recently
from
October 22, 2026 02:44
2981b56 to
c6cab4e
Compare
THardy98
force-pushed
the
review/sticky-activity-polling
branch
from
October 28, 2026 15:47
bcab485 to
1ca71cc
Compare
THardy98
force-pushed
the
review/sticky-activity-polling
branch
from
October 28, 2026 21:08
a029473 to
ee5cf20
Compare
Import temporalio/api sticky-activity-session-options at 6811161a3c59c7773ac236dbf9adf9eb359f9288 as an exact subtree snapshot. Register session messages and keep scheduling and poll session options absent until feature plumbing is implemented. git-subtree-dir: crates/protos/protos/api_upstream git-subtree-split: 6811161a3c59c7773ac236dbf9adf9eb359f9288
Replace crates/protos/protos/api_upstream with an exact snapshot of temporalio/api sticky-activity-session-options at d183f54c642fe320218bc3bf8592b2533540f050, which merges the revised session API shape (temporalio/api#893) and current upstream main.
- Activity session placement uses the WorkflowSession variant; options with no placement keep normal task-queue routing instead of failing. - Session workers send WorkerSessionOptions on sticky polls, advertising that they can serve sessions.
Session workflows should only run, including replay, on workers that serve sessions; replaying elsewhere silently drops the activity affinity the workflow expects. Validate workflow-session activities during replay too, and keep the replay worker's session options instead of clearing them, so a replay worker without session options fails the workflow task.
THardy98
force-pushed
the
review/sticky-activity-polling
branch
from
October 29, 2026 18:02
ee5cf20 to
01c4fb2
Compare
Base automatically changed from
refactor/shared-sticky-poll-admission
to
main
November 2, 2026 17:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
session_worker_options) also poll their sticky queue for activities, sharing slots, rate limiting, and poll admission with normal activity polling.ScheduleActivitycarriesActivitySessionOptions;workflow_sessionroutes the activity to the workflow's sticky queue. Unset keeps normal routing.Why?
Activity affinity for the Sessions API (temporalio/api#885): activities run on the worker running their workflow. Single-session workers and stable identities follow in #1687.
Checklist