fix: implemented status used for TIPs in effect, too - #189
Merged
Conversation
Contributor
Author
|
@SWvheerden Adjustments for the statuses. |
SWvheerden
approved these changes
Jul 22, 2026
SWvheerden
changed the title
SWvheerden
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tweaks the definition of the 'Impelemented' and 'Accepted' statuses to indicate that TIPs without specific implementation which are in effect should use Implemented rather than Accepted.
Motivation and Context
The original definitions meant that a TIP might be in effect when in Accepted status, since TIPs without a specific implementation might be in Accepted status. This could cause confusion because in other cases, a TIP would not be in effect until it reached the Implemented status, as it was waiting on implementation.
How Has This Been Tested?
Locally.