feat: convert types#188
Merged
Merged
Conversation
Kelketek
suggested changes
Jul 17, 2026
Contributor
|
@SWvheerden Left a small comment about Implemented/Accepted status. Other than that, it's working for me. |
Kelketek
suggested changes
Jul 20, 2026
SWvheerden
force-pushed
the
sw_more_fixes
branch
from
July 22, 2026 09:22
001b741 to
2e300f1
Compare
Kelketek
approved these changes
Jul 22, 2026
Kelketek
left a comment
Kelketek
left a comment
Contributor
There was a problem hiding this comment.
@SWvheerden Just one small note. If you address that, it's 👍 from me.
Kelketek
reviewed
Jul 22, 2026
Kelketek
left a comment
Kelketek
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of notes on the wording.
| # Implemented | ||
|
|
||
| Documents in this section describe functionality that has been implemented in the Tari codebase. They form the | ||
| Documents in this section describe functionality that has been implemented in the Tari codebase and or the in effect. They form the |
Contributor
There was a problem hiding this comment.
I think this got mangled. Maybe "or proposals that are otherwise in effect"?
|
|
||
| Documents in this section describe functionality that has been implemented in the Tari codebase. They form the | ||
| Documents in this section describe functionality that has been implemented in the Tari codebase and or the in effect. They form the | ||
| authoritative specification of how the Tari network currently works, covering the base layer, its extensions and |
Contributor
There was a problem hiding this comment.
"how the Tari network and project governance" might be good to specify here.
Contributor
|
@SWvheerden LGTM! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?