Conversation
This was referenced Sep 10, 2026
bigbes
marked this pull request as ready for review
September 16, 2026 14:39
The new pin carries the native search and download engines, the local-directory rock index (remote.FileRemoteIndex, NewIndexes, OrderedIndex) and the LUA_BINDIR derivation from the Tarantool executable. It is the head of the library's master, so it also brings the lua-state isolation between dispatches and the per-dispatch re-evaluation of luarocks.cmd that landed after the engines. The library requires go-git v5.19.2 and newer golang.org/x modules, so those move with it. Related to TNTP-9960
The in-tree orderedIndex and httpIndexes duplicated what the library now ships as remote.NewIndexes plus remote.NewOrderedIndex, with the same first-found-wins semantics. Dropping the copy also picks up the dispatch by server form, so a server entry that names a directory or a file:// URL is read off disk. A directory holding a `manifest` is therefore a rock server anywhere a URL is, including a per-dependency registry override. An empty server list is now an error rather than a silent "rock not found", which is what the library's OrderedIndex reports. Related to TNTP-9960
The registry install path now uses the pure-Go engine, as the path dependencies already did, and so do the search and download wrappers. The Lua interpreter is no longer started for a build, a fetch or a resolve. tt rocks keeps the Lua engine: only that backend can run the full LuaRocks command line, which is what the command exposes. Cover the LUA_BINDIR derivation while here: a flat SDK layout, where the binary sits at the prefix root rather than under bin/, must take the directory of the executable. Related to TNTP-9960
The mock aeon server replaces github.com/tarantool/tt with the checkout, so it inherits the root module's go directive. Without the bump a readonly build refuses: "updates to go.mod needed". Related to TNTP-9960
bigbes
force-pushed
the
bigbes/tntp-9959-go-luarocks-native
branch
from
September 16, 2026 15:37
633d475 to
810a1dd
Compare
Collaborator
Author
|
Diffs per group of changes, rendered on diffshub:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
github.com/tarantool/go-luarocksand moves thett packagedependency pipeline onto the library's pure-Go engine.cli/manifest/rocksdrops its ownorderedIndex/httpIndexesin favour ofremote.NewIndexes+remote.NewOrderedIndex, which have the same first-found-wins semantics. The library dispatches each server entry on its form, so a filesystem path or afile://URL is read off disk — a directory holding a LuaRocksmanifestis now a rock server anywhere a URL is, including a dependency'sregistrykey.tt rocksstays on the Lua backend — only that one can run the full LuaRocks command line.LUA_BINDIRfrom the Tarantool executable, with<prefix>/binonly as a fallback. That is what a flat SDK layout needs, and there is now a test for it.Related to TNTP-9960