Repository navigation
Activate ASP Rust policy through Dev Gate - #20
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e561462c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if cargo_manifest.references_harness_build_dependency | ||
| || cargo_manifest.references_harness_non_optional_normal_dependency | ||
| { |
There was a problem hiding this comment.
In the documented multi-package layout, the Build Support crate is itself a workspace member and normally depends on asp-rust so it can re-export the provider and define the shared macro. The workspace Dev Gate evaluates every workspace member, so this unconditional branch emits R006 when it reaches Build Support and causes mode = deny to reject the recommended setup. The provider-owning Build Support package needs an exemption or separate package-role handling.
Useful? React with 👍 / 👎.
| if (!cargo_manifest.references_harness_dev_dependency | ||
| && !cargo_manifest.is_asp_rust_package | ||
| && !has_build_support_test_gate) | ||
| || !has_cargo_test_gate |
There was a problem hiding this comment.
When a member declares workspace-build-support under [dependencies] and invokes its wrapper from a test target, has_build_support_test_gate is true while the manifest flags only recognize direct asp-rust dependencies. This condition consequently skips R012, and R006 is also absent, so the package is approved even though Build Support and its asp-rust dependency enter the member's normal consumer graph. Verify that the dependency supplying the wrapper is dev-only rather than accepting the wrapper alone.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Dependency
Stacked on PR #18 (agent/asp-contract-alignment).