[Platform] Fix asynchronous job follow-ups from #2408 - #2555
Merged
Merged
Conversation
chr-hertel
force-pushed
the
platform-async-job-followups
branch
3 times, most recently
from
September 20, 2026 23:33
07cebd2 to
68bd7fa
Compare
chr-hertel
force-pushed
the
platform-async-job-followups
branch
from
September 21, 2026 00:19
68bd7fa to
e7af258
Compare
chr-hertel
added a commit
to chr-hertel/ai
that referenced
this pull request
Sep 21, 2026
chr-hertel
added a commit
to chr-hertel/ai
that referenced
this pull request
Sep 22, 2026
chr-hertel
added a commit
to chr-hertel/ai
that referenced
this pull request
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups on #2408, found while reviewing it after the merge. Ships with #2408 in 0.14, so nothing
released changes and no
UPGRADE.mdentry is added — the existing ones are corrected to describewhat will actually ship.
status_code: 0andstatus_msg: "success", which was read as a failure message, so every running job carried"success"inJobStatus::getError(). Verified against the live API.base_respand no state at all, which mapped toUNKNOWN(non-terminal) — the runner then polled it for the whole budget, up to ten minutes for a video handle. It now ends the job, while a state merely spelled in a way the bridge does not know stays non-terminal.JobRunnerturned the budget into a poll count, so the requests themselves were free:maxDuration: 600meant 600 requests plus 599 sleeps. It now waits against a clock deadline.JobClientInterface::supports()had no caller anywhere; the runner asks before polling.MiniMaxResultConverterheld aMiniMaxJobClientonly to read a name off it, building one withnew EventSourceHttpClient()and an empty API key when given none. It takes the name;MiniMaxJobClient::createHandle()and its provider argument go.$minimaxJobClient, but the registered alias isJobClientInterface $minimax, so it never autowired — checked by compiling a container. Also a nullablegetProvider()passed toContainerInterface::get(), an unassigned$id, and examples usingcreateProvider()where every other MiniMax example usescreatePlatform().CHANGELOGheading underline with==in two files;examples/minimax/.gitignoremissed the artifacts the new examples write.All nine MiniMax examples were run against the live API: async speech (9s, real mp3 out of the tar),
video generation (83s, 792 KB mp4) and the resume flow across four processes from the stored handle.
🤖 Generated with Claude Code