Skip to content

[6.1]zero timeout stream data without waiting - #6255

Closed
NathanFreeman wants to merge 5 commits into
swoole:6.1from
NathanFreeman:zero_timeout
Closed

NathanFreeman wants to merge 5 commits into
swoole:6.1from
NathanFreeman:zero_timeout

Conversation

@NathanFreeman

Copy link
Copy Markdown
Member

No description provided.

@matyhtf matyhtf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zero-timeout path itself should remain nonblocking for every subsequent read, but the new regression expects the second fread() to block until the server writes. The PR's own PHP 8.4 Ubuntu CI demonstrates the contradiction: the second read correctly returns an empty string immediately and the new test fails. Please either restore a positive timeout before the second read or wait for readability before asserting the payload. This branch also needs to be updated for merged #6260: PHP_STREAM_OPTION_READ_TIMEOUT is applied to both read and write timeouts here, and the explanatory comment must be preserved.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.31%. Comparing base (bb7880e) to head (85d9355).

Additional details and impacted files
@@           Coverage Diff           @@
##              6.1    #6255   +/-   ##
=======================================
  Coverage   86.30%   86.31%           
=======================================
  Files         110      110           
  Lines       16815    16815           
  Branches     2983     2983           
=======================================
+ Hits        14513    14514    +1     
+ Misses       2302     2301    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants