Repository navigation
Conversation
GNU ld detection requires the version banner printed by `ld -version_details`/`-v` to end in a dash-separated distro release suffix, e.g. "GNU ld version 2.41-28.fc43". Pre-release snapshot builds of binutils, such as Fedora Rawhide's, print a bare dotted version with no such suffix, e.g. "GNU ld version 2.47.50.20260921". Neither existing regex matches that string, so linker discovery fails and raises a hard build error for every linker invocation. Make the trailing release suffix optional, using a non-capturing group so the regex's output type still unifies with its sibling in the same array, so both forms are accepted.
subpop
requested review from
cmcgee1024,
daveinglis,
jakepetroules,
mhrawdon,
owenv,
rconnell9 and
rjmansfield
as code owners
October 17, 2026 03:59
rjmansfield
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU ld detection requires the version banner printed by
ld -version_details/-vto end in a dash-separated distro releasesuffix, e.g. "GNU ld version 2.41-28.fc43". Pre-release snapshot
builds of binutils, such as Fedora Rawhide's, print a bare dotted
version with no such suffix, e.g. "GNU ld version 2.47.50.20260921".
Neither existing regex matches that string, so linker discovery fails
and raises a hard build error for every linker invocation.
Make the trailing release suffix optional, using a non-capturing group
so the regex's output type still unifies with its sibling in the same
array, so both forms are accepted.
[Put a one line description of your change into the PR title, please be specific]
[Explain the context, and why you're making that change. What is the problem you're trying to solve.]
[Tests can be run by commenting
@swift-ci teston the pull request, for more information see this]