Repository navigation
Conversation
rconnell9
requested review from
cmcgee1024,
daveinglis,
jakepetroules,
mhrawdon,
owenv and
rjmansfield
as code owners
October 13, 2026 15:54
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
owenv
approved these changes
Oct 13, 2026
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
4 similar comments
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Contributor
|
@swift-ci test windows |
rjmansfield
reviewed
Oct 15, 2026
rjmansfield
approved these changes
Oct 15, 2026
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test linux |
Contributor
Author
|
@swift-ci test macOS |
Contributor
Author
|
@swift-ci test linux |
1 similar comment
Contributor
Author
|
@swift-ci test linux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is change 2/3 of the adoption of llbuilds new in-memory manifest transfer API.
This change adopts llbuilds new env-bases section to avoid passing duplicate environment variables across commands.
This change does not impact the high level build description. The build description continues to maintains the linkage between each task and its environment. Prior to writing the manifest we scan the environments of each task, adding them (if not a duplicate) as a top-level entry to the llbuild manifest. When commands are written, overrides are computed and inserted when required.
This change should have not impact on the command signature that llbuild computes (the env is simply pulled from a different location in llbuild). In other words this change should not require re-build.
WebKit.xcworkspace)llbuild.xcodeproj)llbuild manifest parse (
llbuild buildsystem parse), 10 runs