Add diagnostics for missing/broken Symbol Links in DocC comments, Tutorial and Markdown files #2729
Open
Padmashree06 wants to merge 16 commits into
Open
Add diagnostics for missing/broken Symbol Links in DocC comments, Tutorial and Markdown files #2729Padmashree06 wants to merge 16 commits into
Padmashree06 wants to merge 16 commits into
Conversation
Padmashree06
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
July 21, 2026 18:12
|
Yes, this will also get refactored, so it might be good to hold off on review until that happens (at least for the bits that use the existing symbol graph logic). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds diagnostics for unresolved symbol links in DocC comments, Markdown, and Tutorial files, using both push and pull diagnostics. For
Swiftfiles, where bothSwiftLanguageServiceandDocumentationLanguageServicecan report diagnostics, the responses from both are merged into a single combined report.Changes
DocumentationLanguageServicefor unresolved symbol references..swiftfiles, merges diagnostics from bothSwiftLanguageServiceandDocumentationLanguageServiceinto a single response (generalizeshandleRequestto support merging responses across language services via an optionalcombineparameter so that the existing callers are unaffected since none of them passcombine)..swiftfiles the push notifications of bothSwiftLanguageServiceandDoucumenattionLanguageServiceare merged and sent to the client.User Impact
Users now see diagnostics (red squiggles) for unresolved symbol links in DocC comments, Markdown and Tutorial files, reported via pull diagnostics where supported and push diagnostics otherwise.