Fix: Committed .grok/settings.json bypasses workspace trust and controls sandbox security posture#340
Open
superagent-security-dev[bot] wants to merge 1 commit into
Conversation
…orkspace trust and controls sandbox security posture
Contributor License AgreementAll contributors are covered by a CLA. |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read sandbox mode and sandbox settings from user settings only (not the committed project file), consistent with the project-hooks and MCP exclusion.
Finding
Committed .grok/settings.json bypasses workspace trust and controls sandbox security posture
Generated by Superagent from the proposed patch for this finding.
Note
Low Risk
Narrow security hardening with predictable behavior change: project sandbox keys in
.grok/settings.jsonare ignored; teams relying on committed sandbox config must move those values to user settings.Overview
Sandbox mode and sandbox settings now come only from user settings (
~/.grok/user-settings.json), not from the repo-committed.grok/settings.json.getCurrentSandboxMode()no longer readsproject.sandboxMode.getCurrentSandboxSettings()no longer mergesproject.sandboxwith user settings and returnsuser.sandbox ?? {}only. This matches the existing policy for project hooks and MCP: committed project config is treated as untrusted for security-sensitive behavior.Reviewed by Cursor Bugbot for commit f1e0b44. Configure here.