Skip to content

feat(pg-delta): enhance pg-delta version handling#5154

Merged
avallete merged 2 commits intodevelopfrom
feat/make-pg-delta-version-pinnable
Apr 30, 2026
Merged

feat(pg-delta): enhance pg-delta version handling#5154
avallete merged 2 commits intodevelopfrom
feat/make-pg-delta-version-pinnable

Conversation

@avallete
Copy link
Copy Markdown
Member

  • Updated the configuration to read the pg-delta npm version from the .temp/pgdelta-version file, defaulting to "1.0.0-alpha.22" if the file is missing or empty.
  • Implemented the InterpolatePgDeltaScript function to replace version placeholders in embedded TypeScript scripts with the effective pg-delta npm version.
  • Modified various functions to utilize the new script interpolation method for executing pg-delta related scripts, ensuring consistent version usage across the application.
  • Added tests to verify the correct behavior of the new version handling and interpolation logic.

This change improves the management of pg-delta versions and enhances the flexibility of script execution.

…ation

- Updated the configuration to read the pg-delta npm version from the `.temp/pgdelta-version` file, defaulting to "1.0.0-alpha.22" if the file is missing or empty.
- Implemented the `InterpolatePgDeltaScript` function to replace version placeholders in embedded TypeScript scripts with the effective pg-delta npm version.
- Modified various functions to utilize the new script interpolation method for executing pg-delta related scripts, ensuring consistent version usage across the application.
- Added tests to verify the correct behavior of the new version handling and interpolation logic.

This change improves the management of pg-delta versions and enhances the flexibility of script execution.
@avallete avallete requested a review from a team as a code owner April 30, 2026 15:09
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25173550370

Coverage decreased (-0.06%) to 63.714%

Details

  • Coverage decreased (-0.06%) from the base build.
  • Patch coverage: 16 uncovered changes across 4 files (0 of 16 lines covered, 0.0%).
  • 7 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
cmd/db_schema_declarative.go 6 0 0.0%
internal/db/diff/pgdelta.go 6 0 0.0%
internal/db/pgcache/cache.go 2 0 0.0%
internal/pgdelta/apply.go 2 0 0.0%

Coverage Regressions

7 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
internal/utils/git.go 5 57.14%
internal/storage/rm/rm.go 2 80.61%

Coverage Stats

Coverage Status
Relevant Lines: 15659
Covered Lines: 9977
Line Coverage: 63.71%
Coverage Strength: 7.03 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@jgoux jgoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@avallete avallete merged commit 0dc6a47 into develop Apr 30, 2026
15 checks passed
@avallete avallete deleted the feat/make-pg-delta-version-pinnable branch April 30, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants