ci: fix release flow order and drop broken npm upgrade step - #357
Merged
Conversation
bgridley-stacks
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the release workflow (
.github/workflows/release.yml), which failed during thepublish-npmstep.1. Drop the broken
Upgrade npmstep. Thepublish-npmjob rannpm install -g npm@latestbefore publishing. Recentnpm@latestships a global install missing the bundledsigstoremodule thatnpm publish --provenancerequires at runtime, so the publish died with:Rerunning was deterministic — same failure every time. The npm bundled with Node 24 (per
.nvmrc) is already provenance-capable, so the manual upgrade was both unnecessary and the cause of the break. Removed it.2. Run the release jobs sequentially. Previously
publish-npm,publish-docker, andgithub-releaseran as independent parallel jobs, so a GitHub release could be cut even if the docker/npm publishes failed. They now chain vianeeds::publish-docker→publish-npm→github-releaseso the release is only created after both artifacts publish successfully.
Breaking change?
No. CI-only change; no application code or public API affected.
Checklist
🤖 Generated with Claude Code