✨ PostgreSQL support - #1191
Conversation
When performing migrations when connected to psql, the container failed to start with error returned from database: column \"completed_at\" is of type timestamp without time zone but expression is of type text". This commit changes the init migraitons to use .timestamp_with_time_zone() instead of .date_time()
This reverts commit e4c3ed4.
|
I can come back to this and make some contributions next week. I was mostly just exploring if I could easily plug in a psql connection setup but found that it required some changes to existing queries. Agree that it would make sense to heavily vet and add testing as I was really in an exploration phase of seeing if I could make it work. Then I stepped away the last week and a half for vacation 😅 Changes to the dockerfile can be reverted entirely (related to the github workflow changes already reverted). I was making attempts to improve the image build time, but no real improvement was made there. |
|
This will go to |
affects sqlite too
i need to think more about this one honestly
|
I haven't encountered anymore postgres issues, doing a sanity pass on sqlite and then will merge this in |
This PR piggybacks off of the work done by another (I became aware from #1167, thank you @sbeckstrand for your work) to add PostgreSQL support. There are a few seemingly unrelated changes in the mix, e.g. cargo chef in the Docker build, that on the surface seem fine but I have yet to meaningfully review. I may wind up pruning to keep this a more focused change, but we'll see.
I'm opening this PR a bit early in the hopes to get better visibility and help seeing it to the finish line. There are quite a few assurances I'd want via testing suites before really seriously considering a merge, since my immediate priority is ensuring existing or future SQLite-based installs do not break.
If you have time to help validate and/or improve, please feel free to base PRs into this branch.
You can provide a fully-resolved connection string via
STUMP_DATABASE_URLor as separate vars:STUMP_DB_PASSWORDSTUMP_DB_HOSTSTUMP_DB_PORTSTUMP_DB_NAMESTUMP_DB_USER